Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Open scenario editor date query once. #10050

Merged
merged 1 commit into from Sep 25, 2022

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Sep 25, 2022

Motivation / Problem

Click and holding on the scenario editor start date widget causes the query text window to be repeatedly opened until the mouse button is released.

Clearing _left_button_clicked causes the button callback to be fired constantly while the mouse button is held.

Description

This is resolved by removing clearing _left_button_clicked, which turns the button into a regular one-shot.

This is probably a leftover from the year decrement/increment buttons which do need this cleared.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Clearing `_left_button_clicked` causes the button callback to be fired
constantly while the mouse button is held.
@PeterN PeterN merged commit 0c20a5f into OpenTTD:master Sep 25, 2022
@PeterN PeterN deleted the scenario-editor-date-query branch September 25, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants