Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Tweak cargo acceptance text display #10056

Merged
merged 2 commits into from Oct 3, 2022

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Sep 27, 2022

Motivation / Problem

Station cargo acceptance text is currently drawn on the main create station window background widget, rather than its own widget (apart from rail stations which already have their own widget). Padding is calculated when drawing the text.

Additionally, the text "Coverage area highlight" is not centred for some of the windows.

Description

This PR introduces a separate widget for the road stop, dock and airport windows, makes the padding the same at the widget level, and also adjusts the spacing for the label.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN merged commit af6c4d5 into OpenTTD:master Oct 3, 2022
@PeterN PeterN deleted the acceptance-text branch October 3, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants