Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: link overlay line width on HiDPI displays #10064

Merged
merged 1 commit into from Oct 4, 2022

Conversation

Bouke
Copy link
Contributor

@Bouke Bouke commented Sep 30, 2022

Motivation / Problem

On HiDPI displays we draw the game at double resolution (GUI scale) to get a consistent physical GUI size. The link graph overlay uses a hard-coded line width of 3 pixels which is not adjusted for GUI scale. This makes the overlay's lines difficult to see, especially to distinguish the different saturation colours. Similar to #9997 this now uses the GUI scaling to translate these 3px to whatever is appropriate for the current GUI scaling level.

Description

Expected:

Actual (12.2):
image

Fix:
image

Limitations

LinkGraphOverlay is initialized on map load. As the GUI scale can be changed in-game, we need to postpone scale the line width to the latest moment possible: on draw.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.
* The bug fix is important enough to be backported? (label: 'backport requested')

  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@glx22 glx22 merged commit c7f55a0 into OpenTTD:master Oct 4, 2022
merni-ns added a commit to merni-ns/OpenTTD that referenced this pull request Jan 25, 2023
…aph GUI lines

From 3px to 2px (multiplied by UI scale).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants