Change: Don't strip symbols from bundles #10071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glx22
reviewed
Oct 6, 2022
Bouke
force-pushed
the
disable-stripping
branch
from
4cab38a
to
5ac8dba
Compare
glx22
approved these changes
Oct 7, 2022
|
As expected the download size for macOS has increased a little (1.55MB, 12%), whereas the bundle size increased somewhat more than expected (8.67MB, 24%). I think this is still acceptable from a cost/benefit perspective. The biggest outlier here is the linux build, which increased significantly both in download size (38.09MB / 270%) and on-disk size (196.35MB / 365%). Is this still acceptable, or should we still strip the binaries for linux bundles?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Improve the readability of stacktraces by not stripping symbols from bundles.
Description
A recent conversation on #openttd regarding crash #10069 let to the discovery that unknowingly symbols got stripped from the published binaries. This results in difficult to read crash logs (stack traces). The overall consensus was that having better stacktraces is worth the little increase in binary size.
Limitations
The macOS bundle size of x64 increased from 24,2 MB to 25,8 MB. CI should be able to give us the changes for the builds we actually publish.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.
* This PR touches english.txt or translations? Check the guidelinesThis PR affects the NewGRF API? (label 'needs review: NewGRF')PR must be added to API tracker