Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: [Actions] use annotation-check v3 #10090

Merged
merged 2 commits into from Oct 20, 2022
Merged

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Oct 19, 2022

Motivation / Problem

annotation-check v2 uses node12 and node12 is being deprecated.

Description

annotation-check v3 uses node16.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

TrueBrain
TrueBrain previously approved these changes Oct 19, 2022
TrueBrain
TrueBrain previously approved these changes Oct 19, 2022
@glx22 glx22 merged commit 87d1bd8 into OpenTTD:master Oct 20, 2022
@glx22 glx22 deleted the annotations branch October 20, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants