Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9087: NewGRF invalidation calls ReInitAllWindows with wrong parameter. #10102

Merged
merged 1 commit into from Oct 23, 2022

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Oct 23, 2022

Motivation / Problem

InvalidateNewGRFChangeWindows() calls ReInitAllWindows() with an incorrect parameter. The parameter should be a boolean indicating whether the GUI zoom has been changed.

Description

GUI zoom does not change during this call, so this is fixed by changing the parameter to false.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN merged commit b04298f into OpenTTD:master Oct 23, 2022
@PeterN PeterN deleted the reinit-fix branch October 23, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants