Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: [CMake] Auto-fill list of #include in script_window.hpp #10103

Merged
merged 1 commit into from Oct 24, 2022

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Oct 23, 2022

Motivation / Problem

Enumerations in script_window.hpp are extracted from headers in a regex generated list.
However the #include lines on top of script_window.hpp are all handwritten in script_window.hpp.in.
So while the enum generation auto detects new files, it is still required to manually add the #include.

Description

Use the regex generated list of headers not only for extracting enumerations but also to automatically fill the #include lines.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Copy link
Member

@PeterN PeterN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gfx_type.h is no longer included in the generated file, I assume this just wasn't needed.

@glx22 glx22 merged commit 0afa6f2 into OpenTTD:master Oct 24, 2022
@glx22 glx22 deleted the widgets branch October 24, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants