Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10164: Incorrect slider handle position in RTL. #10175

Merged
merged 1 commit into from Nov 16, 2022

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Nov 16, 2022

Motivation / Problem

As per #10164, the slider widget handle is incorrectly positioned in RTL.

Description

This is because max_value already had min_value removed to get the slider's range. Therefore min_value needs to be taken from value before adjusting for RTL.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN merged commit 6ea3e7e into OpenTTD:master Nov 16, 2022
@PeterN PeterN deleted the fix-10164 branch November 16, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants