Fix #10181: Show error message on failed industry prospecting #10202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James103
reviewed
Nov 29, 2022
carlossss111
force-pushed
the
silent_prospecting_fail
branch
from
6dec907
to
6ab7f25
Compare
2TallTyler
added
size: trivial
carlossss111
force-pushed
the
silent_prospecting_fail
branch
from
6ab7f25
to
d3bb0e7
Compare
LordAro
reviewed
Nov 29, 2022
glx22
reviewed
Nov 29, 2022
carlossss111
force-pushed
the
silent_prospecting_fail
branch
from
d3bb0e7
to
8433ce2
Compare
carlossss111
force-pushed
the
silent_prospecting_fail
branch
from
8433ce2
to
17f79c5
Compare
carlossss111
force-pushed
the
silent_prospecting_fail
branch
from
17f79c5
to
c4d4e6f
Compare
carlossss111
requested review from
2TallTyler and
PeterN
and removed request for
2TallTyler
2TallTyler
reviewed
Dec 15, 2022
2TallTyler
added
the
work: minor details
michicc
previously requested changes
Dec 25, 2022
Co-authored-by: Michael Lutz <michi@icosahedron.de>
2TallTyler
removed
the
work: minor details
2TallTyler
approved these changes
Dec 25, 2022
glx22
pushed a commit
to glx22/OpenTTD
that referenced
this pull request
Dec 25, 2022
|
Weird I used my super powers to "squash and merge" (which worked as I can see the commit in master), but somehow that didn't close the PR. |
This was referenced Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Fixes the silent fail when prospecting an industry.
Closes #10181
Description
An error message box is displayed when the player fails to prospect an industry by random chance.
Limitations
The error message is not displayed when the map is too full for another industry. I was not sure if this would be in scope.Edit: It's in scopeChecklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.