Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10147: Sound effect volume slider no longer set volume. #10228

Merged
merged 1 commit into from Dec 10, 2022

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Dec 10, 2022

Motivation / Problem

Sound effect volume can no longer be changed from the Game Options window.

Description

#10147 added a SetEffectVolume() function, but this was not called from the Game Options window.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN merged commit daacde4 into OpenTTD:master Dec 10, 2022
@PeterN PeterN deleted the fix-sound-volume-from-settings branch December 10, 2022 15:51
@PeterN PeterN restored the fix-sound-volume-from-settings branch December 10, 2022 17:48
@PeterN PeterN deleted the fix-sound-volume-from-settings branch December 10, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants