Fix #10224: Don't fast forward after autosave if tab key is no longer pressed #10229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… longer pressed If fast forward is via key press
AaronKatzin
changed the title
glx22
reviewed
Dec 10, 2022
glx22
reviewed
Dec 10, 2022
AaronKatzin
force-pushed
the
10224_simpler
branch
from
6dfdcac
to
8c09c3f
Compare
|
Superseded by #10230 - thanks for the PR! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If fast forward is via key press
Motivation / Problem
Fix #10224
Description
Upon autosave, we save game speed in order to restore fast forward upon completion of autosave.
This caused a bug in the case where fast forward was due to key press which was released during the autosave.
So if fast forward is due to key press, save normal game speed. The graphics driver will take care of game speed after the autosave completes just like it does during game-play based on the key being pressed or not.
Limitations
n/a
Checklist for review