Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10242: Allow a space for text shadow when clipping WWT_EMPTY/WWT_TEXT. #10243

Merged
merged 1 commit into from Dec 15, 2022

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Dec 15, 2022

Motivation / Problem

See #10242.

Text drawn inside WWT_EMPTY or WWT_TEXT widgets may have cropped shadows if the widget height is not additionally padded by the widget.

Other widget types are already 'padded' by a bevel, so they are not affected.

Description

This is fixed by allowing extra vertical spacing when setting up the clipping area for a WWT_EMPTY or WWT_TEXT widget. There are still some conditions for this method to work, however it seems good enough in most cases.

Left is master, right is with this change applied.

image

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN merged commit c448eb0 into OpenTTD:master Dec 15, 2022
@PeterN PeterN deleted the fix-10242 branch December 15, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants