New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor sprite aligner enhancements #10249
Conversation
40ce85a
to
cdbd2a2
Compare
cdbd2a2
to
03cc050
Compare
03cc050
to
90783d2
Compare
Millions of force-pushes to satisfy the CI string linter :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the Offset/Sprite centred button should be be lowered depending on its setting. That implies an on/off toggle, not an A/B toggle. I could be easily convinced if there's a reason it's this way. 🙂
True, it was originally a toggle, then I decided to make it clearer with the text changing instead. I'll change it. |
Hmm, actually that's how our buttons work, without it being lowered, the text wouldn't change. See the "Manual" / "Freeform" edges buttons on the terrain generator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, looks fine to me!
Motivation / Problem
Using the debug sprite aligner tool does not give very useful feedback on what is happening when aligning a sprite.
Description
This PR adds two buttons:
The wording and position of the buttons isn't all that great to be honest, but putting them there did mean that the window didn't need to be rearranged.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.