Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Use lowered not disabled widget for current tab in Train Details window. #10252

Merged
merged 1 commit into from Dec 17, 2022

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Dec 17, 2022

Motivation / Problem

The Train Details windows uses disabled widgets to indicate the currently selected tab:

image

While tab-buttons are not often used, all other similar occurences use lowered rather than disabled widgets...

Description

This change uses lowered state for selected tab instead:

image

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

While tab-buttons are not often used, all other similar occurences use
lowered rather than disabled widgets, so use them for train detail
window too.
@PeterN
Copy link
Member Author

PeterN commented Dec 17, 2022

I feel I should mention that this 'active is disabled' behaviour is how it behaves in o.g. TTD, if that is relevant. :)

Copy link
Member

@2TallTyler 2TallTyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not bothered by "it worked this way in TTD" if the new way is better*, more consistent to other menus in OpenTTD (especially if the other menus didn't exist in TTD), and not really a big change to begin with.

*I do consider this to be better, not just more consistent. It's pretty standard UI design that greyed-out buttons are disabled and lowered buttons are active/toggled on.

@PeterN PeterN merged commit 1eecbd3 into OpenTTD:master Dec 17, 2022
@PeterN PeterN deleted the train-details-tabs branch December 17, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants