Change: Vertically centre sprite font relative to TrueType font. #10254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Currently we try to draw the sprite font aligned to the base line of the TrueType font, however this has some issues:
Description
These are mostly resolved here by:
Change when using Liberation Sans size 10 at 2x, old vs new:
Change when using Liberation Sans size 10 at 3x, old vs new:
Change in station label using Liberation Sans size 6 as 2x, old vs new:
(In these screenshots, it is the bus glyph that is incorrectly positioned before this change)
This change also fixes users of static function GetDefaultFontHeight() to call it properly.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.