Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Make vehicle list dropdown buttons resize to fit strings. #10286

Merged
merged 1 commit into from Dec 27, 2022

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Dec 27, 2022

Motivation / Problem

image

(Group) Vehicle list windows used fixed sizes for the dropdown list widgets. This means that they can be either wider or narrow than necessary.

Description

image

This PR determines the width of all the dropdown list strings to dynamic size the dropdown buttons, and alters the layout a bit to maintain the visual appearance across rows.

With English, this results in a narrow window, although with some languages it might be wider.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN merged commit f7e2b6e into OpenTTD:master Dec 27, 2022
@PeterN PeterN deleted the vehicle-list-layout branch December 27, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants