Fix #10331: Starting new company during load must happen after AI start. #10332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterN
added
the
backport requested
rubidium42
reviewed
Jan 8, 2023
… AI start. This situation occurs when loading a savegame in single-player which only has AI companies.
glx22
approved these changes
Jan 8, 2023
|
Tested with only AI companies; works fine in 13-RC1 and with this fix. |
Did you mean "tested with 15 AI companies and no empty slots"? |
michicc
pushed a commit
to michicc/OpenTTD
that referenced
this pull request
Jan 27, 2023
… AI start. (OpenTTD#10332) This situation occurs when loading a savegame in single-player which only has AI companies.
michicc
pushed a commit
to michicc/OpenTTD
that referenced
this pull request
Jan 28, 2023
… AI start. (OpenTTD#10332) This situation occurs when loading a savegame in single-player which only has AI companies.
michicc
pushed a commit
that referenced
this pull request
Jan 28, 2023
…rt. (#10332) This situation occurs when loading a savegame in single-player which only has AI companies.
michicc
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
As per #10331, Loading old savegame with only an AI in it
Starting new company during load must happen after AI start. This situation occurs when loading a savegame in single-player which only has AI companies.
Description
This is resolved by moving the section that creates the new player to the end of the AfterLoadGame() function, just after AI/scripts are started.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.