Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 5e14a20: [GS] Save league table title into string #10479

Conversation

SamuXarick
Copy link
Contributor

@SamuXarick SamuXarick commented Feb 14, 2023

Motivation / Problem

Unnamed, 1955-06-17

GetEncodedText is changing the title to the last non-null text param. In the example screenshot, it's the footer.

Description

Move title handling two lines lower as header and footer are stored in strings anyway

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@SamuXarick SamuXarick force-pushed the save-league-table-title-into-string branch from e8003c1 to 9eeb1e2 Compare February 17, 2023 13:23
@glx22
Copy link
Contributor

glx22 commented Feb 17, 2023

Superseded by #10483

@glx22 glx22 closed this Feb 17, 2023
@SamuXarick SamuXarick deleted the save-league-table-title-into-string branch February 17, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants