Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #10477: Not enough space for text due to rounding down (OSX) #10489

Merged
merged 1 commit into from Feb 18, 2023
Merged

Fix #10477: Not enough space for text due to rounding down (OSX) #10489

merged 1 commit into from Feb 18, 2023

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Feb 17, 2023

Motivation / Problem

As per #10477, Truetype text on OS X may not fit into the space allocated for it.

Description

This is (should be) resolved by rounding the layouter's space up instead of down. Requires testing as I don't run OS X.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

rubidium42
rubidium42 approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@rubidium42 rubidium42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets hope this works

@fmang
Copy link

fmang commented Feb 18, 2023

Tested on macOS 11.7.4. It does solve #10477. Thanks!

@2TallTyler 2TallTyler merged commit 2376112 into OpenTTD:master Feb 18, 2023
@PeterN PeterN deleted the fix-10477 branch February 18, 2023 19:48
@PeterN PeterN added the backport requested This PR should be backport to current release (RC / stable) label Feb 24, 2023
rubidium42 pushed a commit to rubidium42/OpenTTD that referenced this pull request Mar 26, 2023
@PeterN @rubidium42
Fix OpenTTD#10477: Not enough space for text due to rounding down (OS…
9d5844a 
…X) (OpenTTD#10489)
@rubidium42 rubidium42 mentioned this pull request Mar 26, 2023
Merged
rubidium42 pushed a commit to rubidium42/OpenTTD that referenced this pull request Mar 28, 2023
@PeterN @rubidium42
Fix OpenTTD#10477: Not enough space for text due to rounding down (OS…
9c7616c 
…X) (OpenTTD#10489)
rubidium42 pushed a commit that referenced this pull request Mar 31, 2023
@PeterN @rubidium42
Fix #10477: Not enough space for text due to rounding down (OSX) (#10489
addf30e 
)
@rubidium42 rubidium42 added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubidium42 rubidium42 rubidium42 approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PeterN @fmang @rubidium42 @2TallTyler