Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10574: Force town-buildable roads to be not hidden. #10582

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Mar 28, 2023

Motivation / Problem

Some NewGRFs set all town-buildable roads as hidden, which is not the intention of the hidden flag.

Since the hidden flag was enforced, these NewGRFs can no longer be used in the game. As per #10574, map generation fails, and if loading a savegame, towns will not be able to grow.

Description

This is resolved by forcing town-buildable roads to be not hidden.

Limitations

This is just a suggestion of how to work around this issue without reverting the changes which enforce the check.

An alternative is to test if there are no town-buildable roads and then force a non-hidden road to be town-buildable, but that would probably cause different problems.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN
Copy link
Member Author

PeterN commented Mar 28, 2023

Hmm, actually this doesn't wholly fix the issue with buggy NewGRFs. Just because all town-buildable roads are allowed again, doesn't mean a town is able to build a road.

@2TallTyler
Copy link
Member

What are we doing with this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants