Fix #10574: Force town-buildable roads to be not hidden. #10582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Some NewGRFs set all town-buildable roads as hidden, which is not the intention of the hidden flag.
Since the hidden flag was enforced, these NewGRFs can no longer be used in the game. As per #10574, map generation fails, and if loading a savegame, towns will not be able to grow.
Description
This is resolved by forcing town-buildable roads to be not hidden.
Limitations
This is just a suggestion of how to work around this issue without reverting the changes which enforce the check.
An alternative is to test if there are no town-buildable roads and then force a non-hidden road to be town-buildable, but that would probably cause different problems.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.