Fix #8424: Modified Direction Depot Entry Coordinates to Try to Fix Wrongful Collision #10598
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o Fix Wrongful Collision This patch appears to fix the wrongful train crashing, and it changing two directions may be a good sign because it was said the bug was happening in two directions. Counting steps from 5 to 0 also match A to F in number. No process crashing seems to be caused by this, either. However, further testing would be wise.
|
This requires a savegame bump and afterload logic to resolve the situation where the vehicle is at the threshold of going into the depot before this change: oops.zip |
2TallTyler
added
the
work: needs more work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
"#8424: Trains can crash through depots"
Description
This patch appears to fix the wrongful train crashing, and it changing two directions may be a good sign because it was said the bug was happening in two directions. Counting steps from 5 to 0 also match A to F in number. No process crashing seems to be caused by this, either.
Limitations
Further testing would be wise.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.