Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sando matt adding vehicle full value #10654

Closed

Conversation

SandoMatt
Copy link

Motivation / Problem

Description

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

added a new function:
     - GetCurrentChainValue(VehicleID vehicle_id)
@TrueBrain
Copy link
Member

Welcome!

I am not completely sure what happened here .. if you made the PR too soon, or by accident, but I would like to ask you a few things.

In the description you see some questions .. what is your motivations for this change? can you give a description for this change?
If you would be so kind to fill that in, that would be much appreciated.

Currently as it stands, it is hard to judge this contribution. It feels like you solve something that could also have been done in scripting itself. But I might not see the complete picture, and that is why we like motivation and description.

Thank you, and again, welcome to developing for OpenTTD; it is a wonderful place to be at :)

@LordAro LordAro closed this Apr 17, 2023
@SandoMatt
Copy link
Author

SandoMatt commented Apr 17, 2023

Hi!
Totally my fault, I fucked up unintentionally with github making a change to a fork I made to test some things, and pushing it to the main project without being aware of it. Still too green to even thinking of pushing it... My intention is to add some scripting commands to allow new and better economic computations and manipulations, with the idea to make a GS for deeper economic play.

Thanks for the welcoming answer...

I hope I can add something interesting to this great project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants