Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Don't use macros for DAYS_TILL and friends #10746

Merged
merged 1 commit into from May 7, 2023

Conversation

2TallTyler
Copy link
Member

@2TallTyler 2TallTyler commented Apr 30, 2023

Motivation / Problem

We use macros for date lookups.

I needed to change this for my ongoing work with time, but it's no longer necessary. Might as well clean it up, though.

Description

  • Convert the macros in date_type.h into inline functions.

Limitations

  • I have not measured performance changes.
  • There might be better ways to do this.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

src/date.cpp Fixed Show fixed Hide fixed
src/date.cpp Outdated Show resolved Hide resolved
src/date_type.h Outdated Show resolved Hide resolved
@2TallTyler 2TallTyler changed the title Codechange: Convert date macros to functions Codechange: Don't use macros for DAYS_TILL and friends May 1, 2023
src/date_type.h Outdated Show resolved Hide resolved
src/date_type.h Outdated Show resolved Hide resolved
src/date_type.h Outdated Show resolved Hide resolved
@2TallTyler 2TallTyler merged commit 98d809c into OpenTTD:master May 7, 2023
19 checks passed
@2TallTyler 2TallTyler deleted the no-date-macros branch May 7, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants