Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Add padding to build vehicle text filter #10792

Merged
merged 2 commits into from May 8, 2023

Conversation

2TallTyler
Copy link
Member

Motivation / Problem

There was some discussion about making the textbox added in #10519 nicer looking.

Description

filter

The main suggestion was to put the textbox in a panel to provide padding around it. It uses the same amount of padding as other uses like this, namely the sign list.

I also removed the SetMinimalSize() of the textbox, since other elements in this GUI already enforce an appropriate minimum size.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

PeterN
PeterN previously requested changes May 8, 2023
src/build_vehicle_gui.cpp Outdated Show resolved Hide resolved
src/build_vehicle_gui.cpp Outdated Show resolved Hide resolved
@2TallTyler 2TallTyler enabled auto-merge (squash) May 8, 2023 16:16
@2TallTyler 2TallTyler merged commit 61d1b33 into OpenTTD:master May 8, 2023
19 checks passed
@2TallTyler 2TallTyler deleted the filter-padding branch May 8, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants