Fix: when a string consumes more parameters than allowed, nullptr is attempted to be formatted #11002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
When the enforcement of
{STRING}
to not take any parameters is enabled,0
akanullptr
is returned for any{RAW_STRING}
within that string.Most common case is
STR_JUST_STRING
that includes e.g.STR_AI_DEBUG_NAME_AND_VERSION
.Description
Go into the '(invalid RAW_STRING parameter)' branch of formatting when that happens, instead of SIG_SEGV.
Limitations
Doesn't solve the issue that
STR_JUST_STRING
gets used in this way. However, in any case not crashing out is the better solution. Even when the underlying issues get solved. That also allows us to actually enable checking that{STRING}
does not consume any parameters.Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.