Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: use StringParameters for remapping the NewGRF string control codes #11004

Merged
merged 1 commit into from Jun 13, 2023

Conversation

rubidium42
Copy link
Contributor

Motivation / Problem

Passing a pointer and a size, instead of a reference to a structure that contains both.
And further down the line... to make it possible to change the underlying value type for the container.

Description

Replace the uint64 *argv, uint argv_size with StringParameters &parameters in the NewGRF remap function, and map the *argv =/argv[0] =/argv[1] = to the appropriate SetParam call.

Limitations

None.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@rubidium42 rubidium42 merged commit aba0d27 into OpenTTD:master Jun 13, 2023
18 checks passed
@rubidium42 rubidium42 deleted the newgrf-stringparams branch June 13, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants