Change: Allow aqueduct to use foundation #11012
Conversation
There was a problem hiding this comment.
The commit checker is failing because you didn't follow the message format specified in the coding style.
It should be Change: Allow aqueduct to use foundation or similar and then note in the PR description that it closes #10995. It's not a fix because the original choice seems to be intentional.
Also, this does not terraform the end tile, it builds the aqueduct on a foundation. That is a change, since we don't allow flat canals to be built on foundations. A proper "fix" might be to terraform the end slope to allow building the aqueduct without a foundation.
| @@ -408,7 +408,7 @@ CommandCost CmdBuildBridge(DoCommandFlag flags, TileIndex tile_end, TileIndex ti | |||
| } else { | |||
| /* Build a new bridge. */ | |||
|
|
|||
| bool allow_on_slopes = (_settings_game.construction.build_on_slopes && transport_type != TRANSPORT_WATER); | |||
| bool allow_on_slopes = (_settings_game.construction.build_on_slopes ); | |||
There was a problem hiding this comment.
Extra space after conditional
2TallTyler
added
the
work: needs more work
TrueBrain
added
preview
TrueBrain
added
preview
| @@ -408,7 +408,7 @@ CommandCost CmdBuildBridge(DoCommandFlag flags, TileIndex tile_end, TileIndex ti | |||
| } else { | |||
| /* Build a new bridge. */ | |||
|
|
|||
| bool allow_on_slopes = (_settings_game.construction.build_on_slopes && transport_type != TRANSPORT_WATER); | |||
| bool allow_on_slopes = (_settings_game.construction.build_on_slopes ); | |||
There was a problem hiding this comment.
| bool allow_on_slopes = (_settings_game.construction.build_on_slopes ); | |
| bool allow_on_slopes = (_settings_game.construction.build_on_slopes); |
|
This doesn't seem like the right approach, but if anyone feels differently feel free to comment, re-open, etc. I am closing this PR because it appears to be abandoned. |
Motivation / Problem
fix #10995
Description
Removes aqueduct restriction, allowing automatic slope correction while constructing aqueducts.
Limitations
I don't know the side effects, because I don't know why they disabled this functionality for aqueducts.