Codechange: use SetDParam for tooltips #11025
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
The tooltip code has code to manually set parameters for its strings, which yields things like
params[1] = (size_t)details.c_str();
, but it also allows usingSetDParam
/SetDParamStr
but then has a custom implementation for copying the data.So why not unify it to
SetDParam
/SetDParamStr
andCopyOutDParam
, like the other functions handling string formatting parameters?Description
Replace the
params
withSetDParam
/SetDParamStr
.Remove the unneeded
params
parameter.Replace customer parameter copying with
CopyOutDParam
.Reorder arguments to tooltip function, because the close condition is essentially always set whereas the number of parameters is way more often just 0.
Limitations
None.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.