Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #10917 move interest payment before stat generation #11040

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

fwillard
Copy link
Contributor

@fwillard fwillard commented Jun 18, 2023

Motivation / Problem

Loan interest payed in months at end of quarter is incorrectly accounted in the following quarter

closes #10917

Description

Moved call to CompaniesPayInterest() ahead of call to CompaniesGenStatistics() causing interest to be paid prior to accounting for each month/quarter.

Limitations

None

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@James103
Copy link
Contributor

The commit message, while technically fitting the format, is not the best.
I would suggest something like:
Fix #10917: Pay loan interest before generating statistics

@krysclarke
Copy link
Contributor

Somewhat a minor thing, but the past tense of 'pay' is 'paid' not 'payed'.

@glx22 glx22 merged commit f23249f into OpenTTD:master Jun 20, 2023
19 checks passed
@LordAro LordAro added backport requested This PR should be backport to current release (RC / stable) and removed waiting on author labels Jun 28, 2023
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request Jun 28, 2023
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Jun 28, 2023
mrmbernardi pushed a commit to mrmbernardi/OpenTTD that referenced this pull request Jul 2, 2023
shoter pushed a commit to shoter/OpenTTD that referenced this pull request Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Loan interest paid at end of quarter is accounted in next quarter's expenses
6 participants