Fix #11043: Don't choose toolbar dropdown option if focus is lost. #11044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ost. Since dropdown menus now get closed if they lose focus, 'instant close' dropdowns (i.e. the toolbar dropdowns) should no longer execute their action to avoid unintended actions.
PeterN
added
the
backport requested
TrueBrain
approved these changes
Jun 20, 2023
Closed
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this pull request
Jun 28, 2023
…ost. (OpenTTD#11044) Since dropdown menus now get closed if they lose focus, 'instant close' dropdowns (i.e. the toolbar dropdowns) should no longer execute their action to avoid unintended actions.
LordAro
pushed a commit
that referenced
this pull request
Jun 28, 2023
LordAro
added
backported
mrmbernardi
pushed a commit
to mrmbernardi/OpenTTD
that referenced
this pull request
Jul 2, 2023
…ost. (OpenTTD#11044) Since dropdown menus now get closed if they lose focus, 'instant close' dropdowns (i.e. the toolbar dropdowns) should no longer execute their action to avoid unintended actions.
shoter
pushed a commit
to shoter/OpenTTD
that referenced
this pull request
Jul 16, 2023
…ost. (OpenTTD#11044) Since dropdown menus now get closed if they lose focus, 'instant close' dropdowns (i.e. the toolbar dropdowns) should no longer execute their action to avoid unintended actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
As per #11043, the game may crash if a window pops up while using the rail type toolbar menu.
Description
Since dropdown menus now get closed if they lose focus, 'instant close' dropdowns (i.e. the toolbar dropdowns) should no longer execute their action to avoid unintended actions.
Limitations
Possibly the dropdown menu should not lose focus if other windows popup without user interation, but that is another thing.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.