Fix: Layouter reverse-mapping to characters #11060
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Mapping back from a glyph to a character index in the source string should work, even with multiple run and when formatting codes are involved.
Description
Have visual runs keep track of their offsets in the input text.
Count formatting codes the same way in both forward and reverse mapping.
Limitations
Not thoroughly tested recently, but this fixed something when I was working on #7786 originally. (Reverse-mapping is relevant for hit-testing mouse clicks against individual character glyphs.)
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.