Change: Allow text shadow on WWT_EMPTY/WWT_TEXT to extend horizontally. #11065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Text shadow of truetype fonts is sometimes cropped when displayed. This is because the shadow isn't included in the width of the text string for truetype fonts, so the widget clipping prevents it from appearing. This does not affect the sprite font which has the shadow baked in and included in the glyph width.
This also only affects text which fits the widget width exactly, or right-aligned text.
Description
This PR allows the text to extend the widget bounds by 1 scaled pixel horizontally. This alleviates text shadows of truetype fonts being cropped in some window layouts. While not technically correct, in most cases this should be sufficient. Note however that this extra scaled pixel is already allowed vertically, which improved shadows on letters with descenders.
To properly include the shadow width in string width calculations so that it matches how the sprite font behaves is likely quite complex to get right as there are multiple layouters with different places to get right/wrong. Simply increasing the character width would make kerning wrong.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.