Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Allow text shadow on WWT_EMPTY/WWT_TEXT to extend horizontally. #11065

Merged
merged 1 commit into from Jun 25, 2023

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Jun 24, 2023

Motivation / Problem

Text shadow of truetype fonts is sometimes cropped when displayed. This is because the shadow isn't included in the width of the text string for truetype fonts, so the widget clipping prevents it from appearing. This does not affect the sprite font which has the shadow baked in and included in the glyph width.

This also only affects text which fits the widget width exactly, or right-aligned text.

image

Description

This PR allows the text to extend the widget bounds by 1 scaled pixel horizontally. This alleviates text shadows of truetype fonts being cropped in some window layouts. While not technically correct, in most cases this should be sufficient. Note however that this extra scaled pixel is already allowed vertically, which improved shadows on letters with descenders.

To properly include the shadow width in string width calculations so that it matches how the sprite font behaves is likely quite complex to get right as there are multiple layouters with different places to get right/wrong. Simply increasing the character width would make kerning wrong.

image

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

This alleviates text shadows of truetype fonts being cropped in some
window layouts.
@PeterN PeterN merged commit 43ddf19 into OpenTTD:master Jun 25, 2023
18 checks passed
@PeterN PeterN deleted the allow-shadow branch June 25, 2023 10:58
mrmbernardi pushed a commit to mrmbernardi/OpenTTD that referenced this pull request Jul 2, 2023
…y. (OpenTTD#11065)

This alleviates text shadows of truetype fonts being cropped in some
window layouts.
shoter pushed a commit to shoter/OpenTTD that referenced this pull request Jul 16, 2023
…y. (OpenTTD#11065)

This alleviates text shadows of truetype fonts being cropped in some
window layouts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants