Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Set default company secondary colour for new games #11068

Merged
merged 1 commit into from Jul 26, 2023

Conversation

M3Henry
Copy link
Contributor

@M3Henry M3Henry commented Jun 24, 2023

Motivation / Problem

The primary company colour for new games is a config option. However the secondary colour always assumes the same as the primary colour. It would be nice to be able to set both independently.

Description

Add secondary company colour to config and use that in new games if set. Allowed options are:

  • "Same as Primary CC" (default)
  • "Colour"...

Limitations

Options could include:

  • "Random (not same as Primary CC)"
  • "Completely Random"
  • "Complementary of Primary CC"
  • "Shade / Tint of Primary CC"

Other things that might be interesting?

  • Generate a full set of random 1CC/2CC liveries: by group and/or type
  • Also use setting for companies started during multiplayer
  • This only sets the Global secondary company colour, going more granular might be good, or might not be.

Checklist for review

  • This PR touches english.txt or translations? Check the guidelines

@M3Henry M3Henry marked this pull request as draft June 24, 2023 21:23
@2TallTyler 2TallTyler added the preview This PR is receiving preview builds label Jun 25, 2023
@DorpsGek DorpsGek temporarily deployed to preview-pr-11068 June 25, 2023 11:12 Inactive
@TrueBrain TrueBrain added preview This PR is receiving preview builds and removed preview This PR is receiving preview builds labels Jul 8, 2023
@TrueBrain TrueBrain added preview This PR is receiving preview builds and removed preview This PR is receiving preview builds labels Jul 8, 2023
@TrueBrain TrueBrain temporarily deployed to preview July 8, 2023 12:14 — with GitHub Actions Inactive
@M3Henry M3Henry temporarily deployed to preview July 13, 2023 22:14 — with GitHub Actions Inactive
@M3Henry M3Henry marked this pull request as ready for review July 13, 2023 22:19
Copy link
Member

@2TallTyler 2TallTyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to add the other colour options (tint, complementary, etc) in this PR, or leave them for later? I think this stands alone, but don't want to be hasty with an approval. 😃

src/lang/english.txt Outdated Show resolved Hide resolved
@M3Henry M3Henry temporarily deployed to preview July 15, 2023 09:55 — with GitHub Actions Inactive
2TallTyler
2TallTyler previously approved these changes Jul 15, 2023
src/openttd.cpp Outdated Show resolved Hide resolved
@2TallTyler 2TallTyler dismissed their stale review July 25, 2023 19:51

Changes requested

…r new games

This does duplicate translation strings for the colours
@rubidium42 rubidium42 merged commit a9c65a6 into OpenTTD:master Jul 26, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview This PR is receiving preview builds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants