Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Setting tree lines drawn incorrectly for RTL languages. #11070

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Jun 25, 2023

Motivation / Problem

Setting tree lines are drawn incorrectly for RTL languages. At best case the lines are not drawn, at worst case the game can crash in a blitter.

image

(The blue labels is something else that needs fixing separately)

Description

Fixed by:

  1. casting both sides of circle_size ternary result to int to prevent unintended promotion of the just-cast int to unsigned int.
  2. Taking account of RTL when applying hsep_normal offset.

image

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN added the backport requested This PR should be backport to current release (RC / stable) label Jun 25, 2023
@PeterN PeterN merged commit d140acf into OpenTTD:master Jun 25, 2023
19 checks passed
@PeterN PeterN deleted the fix-rtl-settings-lines branch June 25, 2023 18:33
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request Jun 28, 2023
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Jun 28, 2023
mrmbernardi pushed a commit to mrmbernardi/OpenTTD that referenced this pull request Jul 2, 2023
shoter pushed a commit to shoter/OpenTTD that referenced this pull request Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants