Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix d5a72193: [CI] downloading single artifact doesn't add folder to it #11107

Merged
merged 1 commit into from Jul 4, 2023

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

The download-artifact action has two modes: download all or download one.

In the first mode, it downloads all artifacts prefixed with their artifact name.
In the second mode, it doesn't do this.

These differences .. owh well .. but in result the Steam/GOG release failed, as they assumed the artifacts are in the folder.

Description

There are two choices: remove the assumption the artifacts are in the folder, or add the folder. I did the latter, as the first can be a bit tricky. Say, by accident, one of the targets outputs a file with the same name as another target. It would now overwrite this. We can't have that! So, put artifacts in their own folder.

Limitations

Still untested, so we will see tomorrow night if this works :)

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain enabled auto-merge (squash) July 4, 2023 20:02
@TrueBrain TrueBrain merged commit 83b6512 into OpenTTD:master Jul 4, 2023
18 checks passed
@glx22 glx22 added the backport requested This PR should be backport to current release (RC / stable) label Jul 29, 2023
glx22 pushed a commit to glx22/OpenTTD that referenced this pull request Jul 29, 2023
@glx22 glx22 added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Jul 29, 2023
@TrueBrain TrueBrain deleted the ci-artifact-issues branch January 18, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants