Change: Clean up window title and button capitalization and wording #11134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Knock knock, it's the grammar police!
Not really, but while reviewing #10541 I tried to ensure its new windows and button matched our current precedent, and discovered that our current precedent is a bit messy. Not totally random — we have some reasonably consistent rules — but with enough outliers for it to be frustrating.
Description
Let's clean up the easy outliers and make them match the pattern we've generally established:
Generally title case unless they're a sentence fragment:
I reworded the easy sentence fragments and left the tricky ones alone for later (or never 😛).
Always (to my knowledge) sentence case:
I also fixed some confusion with AI and GS setting windows, where all the buttons say "settings" but the windows themselves say "configuration". I went with "settings" because our use of the synonyms "options" and "settings" is confusing enough without adding "configuration" to the list. 😃
I made a bunch of commits for reviewers to easily follow, will squash when merging.
Most likely supersedes #9118.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.