Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: [Script] GSIndustry.GetConstructionDate() method #11145

Merged
merged 1 commit into from Jul 20, 2023

Conversation

andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Jul 17, 2023

Motivation / Problem

  • For features or gameplay changes:
    • What was the motivation to develop this feature?
      • Provide GS with access to industry construction date
    • Does this address any problem with the gameplay or interface?
      • GS did not have access to industry construction date
    • Which group of players do you think would enjoy this feature?
      • Players who wish to use GS that depends on industry construction date

Description

Describe here shortly

  • For features or gameplay changes:
    • What does this feature do?
      • Provides GS with access to industry construction date
    • How does it improve/solve the situation described under 'motivation'.
      • GS has access to industry construction date

Limitations

Describe here

  • Is the problem solved in all scenarios?
    • Yes
  • Is this feature complete? Are there things that could be added in the future?
    • Yes. No.
  • Are there things that are intentionally left out?
    • No
  • Do you know of a bug or corner case that does not work?
    • No

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
    • No
  • This PR touches english.txt or translations? Check the guidelines
    • No
  • This PR affects the save game format? (label 'savegame upgrade')
    • No
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
      • Yes, needs updating
    • The compatibility wrappers (compat_*.nut) need updating.
      • Don't know
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@andythenorth andythenorth force-pushed the gs-industry-constructed-date branch 2 times, most recently from ce14186 to 7334924 Compare July 17, 2023 20:24
@glx22
Copy link
Contributor

glx22 commented Jul 18, 2023

As you mentioned in the checklist, you need to update changelog :)

Copy link
Contributor

@rubidium42 rubidium42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compat scripts only need to be updated when some API gets changed. This is just a simple addition.

@michicc michicc merged commit ce9305a into OpenTTD:master Jul 20, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants