Codechange: Add a DateToYear function instead of dividing each time #11173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
We do a lot of math with dates, so #10761 needs to do a lot of casting.
Description
Instead of repeatedly dividing by
DAYS_IN_LEAP_YEAR
to get the year from a date, add a function that does this calculation. It's more readable and we only have to cast once.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.