Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Add a DateToYear function instead of dividing each time #11173

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

2TallTyler
Copy link
Member

Motivation / Problem

We do a lot of math with dates, so #10761 needs to do a lot of casting.

Description

Instead of repeatedly dividing by DAYS_IN_LEAP_YEAR to get the year from a date, add a function that does this calculation. It's more readable and we only have to cast once.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@2TallTyler 2TallTyler merged commit 6190f48 into OpenTTD:master Aug 11, 2023
19 checks passed
@2TallTyler 2TallTyler deleted the date-to-year branch August 11, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants