Fix: Trivial autoreplace of mixed cargo articulated engines #11253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGRennison
force-pushed
the
fix-trivial-autoreplace-of-mixed-cargo-articulated-vehicles
branch
from
ab7077d
to
085c6aa
Compare
|
I can't review the code, but this addresses a long-standing issue and would be an improvement to OpenTTD. Low-to-no chance of pitchforks. |
2TallTyler
force-pushed
the
fix-trivial-autoreplace-of-mixed-cargo-articulated-vehicles
branch
from
085c6aa
to
ae8301f
Compare
2TallTyler
previously approved these changes
Nov 3, 2023
|
Needs a rebase now. 😕 |
Do not fail autoreplace/autorenew of mixed cargo articulated engines due to an inability to refit to mixed cargoes, when no refit is required because the target engine already has a suitable set of cargoes. Notably, this allows autorenew (autoreplace to same engine type) to succeed.
JGRennison
force-pushed
the
fix-trivial-autoreplace-of-mixed-cargo-articulated-vehicles
branch
from
ae8301f
to
0891329
Compare
2TallTyler
approved these changes
Nov 19, 2023
JGRennison
deleted the
fix-trivial-autoreplace-of-mixed-cargo-articulated-vehicles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Autoreplace/autorenew currently fails for mixed cargo articulated engines, even when there is no reason to do so.
Description
Do not fail autoreplace/autorenew of mixed cargo articulated engines due to an inability to refit to mixed cargoes, when no refit is required because the target engine already has a suitable set of cargoes.
Notably, this allows autorenew (autoreplace to same engine type) to succeed.
Limitations
N/A
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.