Codechange: Use member initalisers #11304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
reviewed
Sep 15, 2023
| @@ -207,12 +207,8 @@ struct PacketWriter : SaveFilter { | |||
| * Create a new socket for the server side of the game connection. | |||
| * @param s The socket to connect with. | |||
| */ | |||
| ServerNetworkGameSocketHandler::ServerNetworkGameSocketHandler(SOCKET s) : NetworkGameSocketHandler(s) | |||
| ServerNetworkGameSocketHandler::ServerNetworkGameSocketHandler(SOCKET s, NetworkAddress client_address) : NetworkGameSocketHandler(s, _network_client_id++), status(STATUS_INACTIVE), receive_limit(_settings_client.network.bytes_per_frame_burst), client_address(client_address) | |||
There was a problem hiding this comment.
Lol, two years later, same comment: please don't do a ++ in a ctor initializer like this. That is going to be overlooked and will bite us in the ass :) ctor member initializer should be without side-effects. Side-effects go in the body.
|
Also, this PR should target master, not a release branch. |
|
This seems like change for the sake of change, and hasn't been touched since being reviewed. I am closing it, but as always if anyone disagrees feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Looking at the code, I saw several occasions in which member initialisation could be done directly.
Description
Use member initialisers
Limitations
Definitely partial changes, but maybe a step in a good direction?
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.