Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Cheat to fix station ratings at 100% #11346

Merged
merged 1 commit into from Oct 21, 2023

Conversation

2TallTyler
Copy link
Member

Motivation / Problem

Station Ratings are generally considered to be a Bad Feature that prevent some gameplay styles, like running infrequent services with a low economy scale (#10606) to simulate a slower game, especially once we have configurable calendar speed.

Description

Upstream a JGRPP cheat to fix station ratings at 100%.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@2TallTyler 2TallTyler added the preview This PR is receiving preview builds label Oct 1, 2023
@2TallTyler 2TallTyler temporarily deployed to preview October 1, 2023 18:35 — with GitHub Actions Inactive
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit, imo

src/station_cmd.cpp Outdated Show resolved Hide resolved
src/lang/english.txt Outdated Show resolved Hide resolved
src/saveload/cheat_sl.cpp Outdated Show resolved Hide resolved
@2TallTyler 2TallTyler temporarily deployed to preview October 2, 2023 12:34 — with GitHub Actions Inactive
@2TallTyler 2TallTyler merged commit 2dd2910 into OpenTTD:master Oct 21, 2023
21 checks passed
@2TallTyler 2TallTyler deleted the station-rating-cheat branch October 21, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview This PR is receiving preview builds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants