Change: Try stopping extmidi player with SIGINT first. #11404
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
On Linux with extmidi music playback, stopping playback or switching to the next track may leave stuck notes. This is because it's down to the external player to turn those notes off, and we kill the process with SIGTERM which can interrupt this.
Description
Instead, try sending SIGINT first, and if that fails fall back to SIGTERM then SIGKILL. This can give the player a chance to issue MIDI note-off commands.
This fixes at least pmidi leaving stuck notes on.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.