Feature: Show cargo icon on cargo filter lists. #11487
Conversation
src/widgets/dropdown_type.h
Outdated
|
|
||
| /* Commonly used drop down list items. */ | ||
| using DropDownListDividerItem = DropDownDivider<DropDownListItem>; | ||
| using DropDownListStringItem = DropDownString<DropDownDivider<DropDownListItem>>; |
There was a problem hiding this comment.
I don't fully get why DropDownDivider as base of DropDownString
There was a problem hiding this comment.
Because the old base DropDownListItem provided the divider itself. The alternative is to undo #11447, and explicitly create a DropDownListDividerItem. That may not be too much hassle now.
|
Good idea, it will really improve the clarity of filter lists! |
|
We discussed icons before the text on Discord. It didn't look great because icons are all different sizes, so their alignment with text looks bad. I'd rather see the dropdown clamped to a suitable width (using a spacer to fill the empty space) to avoid the problem. 🙂 |
|
I wasn't making this up...
https://github.com/OpenTTD/OpenTTD/assets/639850/7d09d6bd-3505-4d04-a26e-7f305ed03a9b |
|
Arguably the icons don't match well in width. However that's a task for the (New)GRF authors to take care of. The list with the icons on the left still looks better to me than with the icons on the right with the huge separation from the text. Could the maximum size of the icons be chosen as icon column width and all icons be centered wrt the icon column instead of left-aligned to make it look better? |
|
|
|
Add a setting ;) But I do agree that slightly less of a gap would be better |
|
|
|
And with a checkmark, which is also on the left to match the menu items on the settings toolbar menu: https://github.com/OpenTTD/OpenTTD/assets/639850/6d49a92e-ace2-42cf-a46b-e47e19c9a53e |
Default parameters allowed Dimension to be constructed with only a width. Instead use separate empty and width/height constructors to ensure that either none or both are provided.
This allows list items to built from component parts as required, and additional functionality is added: * Icons and text can be positioned at the start or end of the space (templated.) * Font size of text can be changed (templated.) * Palette of sprites can be set (runtime.)
This avoids the need to construct a DropDownIcon and set the dimension after.
Reveal the pixel art.
PeterN
force-pushed
the
cargo-filter-cargo-icon
branch
from
c106350
to
3c72ff3
Compare
|
Okay, now changed to put the icon on the left, along with a few other changes to make that easier to perform. First commit is because I ran into an issue where any integer could be converted to a Dimension of height 0 unintentionally... |
| Dimension dim; ///< Dimensions of string. | ||
| public: | ||
| template <typename... Args> | ||
| explicit DropDownString(StringID string, Args&&... args) : TBase(std::forward<Args>(args)...) |
There was a problem hiding this comment.
Oh, nice idea/trick when using CRTP.
Motivation / Problem
Cargo icons are only visible in the station view window, when stations have waiting cargo. Painstakingly drawn 10 pixel high pixel art masterpieces are being denied to us.
Description
Add cargo icons to cargo filter dropdown lists, and revel in beauty of them.
Cargo icons have various widths so we have a function to get the largest and make sure all items use the same width.
Cargo icons have various widths so they are drawn at the end of the item. Other positions were tested and were less visually coherent.This also introduces the CRTP (Curiously Recursive Template Pattern) redesign for drop down list items, which allows them to be composed of various parts instead of to a fixed design, but unfortunately means they are templates to are implemented in the head filters.
https://github.com/OpenTTD/OpenTTD/assets/639850/00fe6c55-118b-4eff-86a5-38de324e123eLimitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.