Codechange: Use a few less NUM_CARGO loops. #11499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces indexed array access.
rubidium42
approved these changes
Nov 27, 2023
Comment on lines
1375
to
1379
| int r = 0; | ||
| for (CargoID i = 0; i < NUM_CARGO; i++) { | ||
| r = diff[i]; | ||
| for (uint d : diff) { | ||
| r = d; | ||
| if (r != 0) break; | ||
| } |
There was a problem hiding this comment.
Couldn't this be something along the line of the following?
auto it = std::find_if(diff.begin(), diff.end(), [](auto d) { return d != 0; });
return it != diff.end() ? *it < 0 : VehicleNumberSorter(a, b);
It's sort of a recurring pattern with the capacities as well, though there the code is smaller than it's here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Reducing the use of 0 - NUM_CARGO loops. for-loops that index into an array which can use range-for or std::max_element.
Description
Replace some loops with range-for or std::max_element.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.