Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Incorrect mask files for NE river slopes #11503

Merged
merged 1 commit into from Nov 27, 2023

Conversation

zephyris
Copy link
Contributor

Motivation / Problem

origwindows_rivershadeglitch

A gray bar is visible when two or more NE facing river slopes are next to each other.

Description

The cause is an incorrect mask sprite for the NE river slopes. It is only visible when two or more tiles are next to each other as the river bank sprites normally cover the gray bar.

Limitations

None

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN merged commit a856fbe into OpenTTD:master Nov 27, 2023
19 checks passed
@zephyris zephyris deleted the river-slope-shading-fix branch February 27, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants