Change: Don't change music track when toggling shuffle mode. #11504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Toggling shuffle mode instantly changes the currently playing music track.
I think it is better for toggling shuffle mode to only affect the playlist order, with no other side effects.
Description
Instead of restarting play back when toggling shuffle, remember the current playlist song and update the playlist position.
Additionally, fix an oversight that meant the playlist window itself is not refreshed when toggling shuffle mode.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.