Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Don't change music track when toggling shuffle mode. #11504

Merged
merged 2 commits into from Nov 27, 2023

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Nov 27, 2023

Motivation / Problem

Toggling shuffle mode instantly changes the currently playing music track.

I think it is better for toggling shuffle mode to only affect the playlist order, with no other side effects.

Description

Instead of restarting play back when toggling shuffle, remember the current playlist song and update the playlist position.

Additionally, fix an oversight that meant the playlist window itself is not refreshed when toggling shuffle mode.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN merged commit ab1a4c6 into OpenTTD:master Nov 27, 2023
19 checks passed
@PeterN PeterN deleted the shuffle branch November 27, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants