Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Template input buffer type in audio mixer. #11505

Merged
merged 1 commit into from Nov 28, 2023

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Nov 27, 2023

Motivation / Problem

The mix_int16 and mix_int8_to_int16 audio mixer functions are quite long and are very similar, save for a type difference and a shift factor.

Description

Add the type and the shift factor as template parameters to mix_int16 (int16 is the output type here which does not change) to reduce code duplication.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

rubidium42
rubidium42 previously approved these changes Nov 27, 2023
src/mixer.cpp Outdated Show resolved Hide resolved
@PeterN PeterN merged commit 3df7d1a into OpenTTD:master Nov 28, 2023
20 checks passed
@PeterN PeterN deleted the mixer-template branch November 28, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants