Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Add tooltips for text file buttons, and shorten Website / Readme buttons. #11534

Merged
merged 1 commit into from Dec 3, 2023

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Dec 3, 2023

Motivation / Problem

  • The Readme and Changelog and Licence buttons that open the text file viewer don't have a tooltip.
  • It is inconsistent that Readme is prefixed with "View", but Changelog and Licence are not.

Description

  • Add tooltips for the these buttons.
  • Change 'View Readme' to 'Readme', and also 'Visit Website' to 'Website' for consistency. As these buttons have tooltips there should not be any ambiguity with their meaning.

This is separate from the existing PR that rearranges the buttons themselves.

image

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN enabled auto-merge (squash) December 3, 2023 16:34
@PeterN PeterN merged commit 9a92e02 into OpenTTD:master Dec 3, 2023
19 checks passed
@PeterN PeterN deleted the tooltips branch December 3, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants