Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: SetMinimalTextLines(1, 0) is implied for widgets with text. #11536

Merged
merged 1 commit into from Dec 3, 2023

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Dec 3, 2023

Motivation / Problem

Some widget layouts include SetMinimalTextLines(1, 0) parts even though the widget is a standard text or text button widget, which will automatically have 1 text line.

Description

Remove the unnecessary SetMinimalTextLines(1, 0) parts. No visual change, this just reduces layout complexity.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN enabled auto-merge (squash) December 3, 2023 22:24
@PeterN PeterN merged commit 9122b4e into OpenTTD:master Dec 3, 2023
19 checks passed
@PeterN PeterN deleted the less-setminimaltextlines branch December 4, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants