Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use newgame ending year on highscore table when not in a game. #11545

Closed
wants to merge 1 commit into from

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Dec 5, 2023

Motivation / Problem

Highscore table uses the game end year from the _settings_game settings even when in the intro screen. This (probably) displays the intro game's end year instead of the configured end year.

image

Description

When not in a game, use the _settings_newgame end year setting instead.

image

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

src/highscore_gui.cpp Outdated Show resolved Hide resolved
If ending year is set to never, then use the default end year instead.
@PeterN
Copy link
Member Author

PeterN commented Dec 9, 2023

This change is pointless if #11546 is preferred.

@PeterN PeterN closed this Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants